Skip to content

[AWS] Add missing permissions in the AWS Billing integration documentation #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2023
Merged

[AWS] Add missing permissions in the AWS Billing integration documentation #5791

merged 3 commits into from
Apr 7, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Apr 4, 2023 •
edited
Loading

What does this PR do?

Add two missing permissions to the AWS integration docs.

  • ce:GetCostAndUsage
  • organizations:ListAccounts

The source list comes from the Metricbeat docs:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog zmoog added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Apr 4, 2023
@zmoog zmoog self-assigned this Apr 4, 2023
@zmoog zmoog marked this pull request as ready for review April 4, 2023 16:04
@zmoog zmoog requested a review from a team as a code owner April 4, 2023 16:04
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-07T15:19:57.131+0000

  • Duration: 49 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.073
Classes 93.75% (15/16) 👎 -3.073
Methods 86.131% (236/274) 👎 -5.987
Lines 85.925% (7387/8597) 👎 -5.349
Conditionals 100.0% (0/0) 💚

@zmoog zmoog force-pushed the zmoog/add-missing-permission-for-aws-billing branch from d9cefb8 to 8706bab Compare April 7, 2023 14:57
@zmoog zmoog force-pushed the zmoog/add-missing-permission-for-aws-billing branch from 8aca98d to e1d3289 Compare April 7, 2023 15:19
@zmoog zmoog changed the title [AWS] Add missing permissions for AWS Billing input [AWS] Add missing permissions in the AWS Billing integration documentation Apr 7, 2023
@zmoog zmoog merged commit ee992bf into main Apr 7, 2023
@zmoog zmoog deleted the zmoog/add-missing-permission-for-aws-billing branch April 7, 2023 16:57
@elasticmachine
Copy link

Package aws - 1.33.2 containing this change is available at https://epr.elastic.co/search?package=aws

@alaudazzi alaudazzi mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees

@zmoog zmoog

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmoog @elasticmachine @endorama @andrewkroh