Throw proper error for FieldValue transforms in arrays #3183
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
dconeybe
approved these changes
Jun 8, 2020
| @@ -214,6 +214,7 @@ export class FirebaseCredentialsProvider implements CredentialsProvider { | |||
| // outstanding so the response is potentially for a previous user (which | |||
| // user, we can't be sure). | |||
| if (this.tokenCounter !== initialTokenCounter) { | |||
| this.forceRefresh = true; | |||
There was a problem hiding this comment.
Is this change related to the fix at hand?
There was a problem hiding this comment.
No, this is meant for a different PR. Removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #3048 which changed the context.path variable from
Path|nulltoundefined|null.Fixes #3172