Skip to content

[Auth] Update auth token logic to rely on device clock time instead of server time #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2020
Merged

[Auth] Update auth token logic to rely on device clock time instead of server time #4210

merged 4 commits into from
Dec 15, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Dec 15, 2020

See cl/343354267, cl/347495710.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2020 •
edited
Loading

🦋 Changeset detected

Latest commit: 3df20fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sam-gc sam-gc requested a review from yuchenshi December 15, 2020 00:58
@sam-gc sam-gc requested a review from bojeil-google December 15, 2020 00:58
@sam-gc sam-gc marked this pull request as ready for review December 15, 2020 00:58
@sam-gc sam-gc requested a review from avolkovi as a code owner December 15, 2020 00:58
@sam-gc sam-gc requested a review from hsubox76 December 15, 2020 00:59
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 15, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (4418d78) and head commit (68ec30c).

Test Logs

@sam-gc sam-gc merged commit 9fd3f52 into master Dec 15, 2020
@sam-gc sam-gc deleted the samgho/auth-token branch December 15, 2020 16:38
@google-oss-bot google-oss-bot mentioned this pull request Dec 16, 2020
Merged
@yusufkandemir yusufkandemir mentioned this pull request Dec 23, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@avolkovi avolkovi Awaiting requested review from avolkovi

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@hsubox76 hsubox76

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-gc @google-oss-bot @yuchenshi @hsubox76