Storage Emulator "Fast-Follow" Bug Fixes #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bfecd2 to
ec366f8
Compare
samtstern
reviewed
May 26, 2021
| } | ||
|
|
||
| private deleteFieldsSetAsNull() { | ||
| const deletableFields: (keyof this)[] = [ |
There was a problem hiding this comment.
I just learned a new trick!
samtstern
reviewed
May 26, 2021
|
|
||
| if (this.customMetadata) { | ||
| Object.keys(this.customMetadata).map((key: string) => { | ||
| if (!this.customMetadata) return; |
There was a problem hiding this comment.
This if seems to conflict with the outer if(this.customMetadata) ...
There was a problem hiding this comment.
it doesn't conflict cause it's saying "if I have custom metadata do this" then "if I dont have custom metadata dont do this" but it is weird cause it's like a double check. I had to add this cause typescript was getting confused and ignoring my explicit check of this.customMetadata in the outer if thinking it could still be undefined in the inner one so I had to check again.
Tho it occurs to me that if I use a for look it'll probably fix this so I'll probably just do that.
samtstern
approved these changes
May 26, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Changelog.md for details.