Skip to content

Commit 4dfbe5a

Browse files
authored
fix(core, apple): remove usage of deprecated options trackingID and androidClientID (#11893)
* fix(core, apple): remove usage of deprecated options trackingID and androidClientID * fix(core, apple): remove usage of deprecated options trackingID and androidClientID * update tests * tests
1 parent 12dc8f3 commit 4dfbe5a

File tree

6 files changed

+5
-19
lines changed

6 files changed

+5
-19
lines changed

packages/firebase_core/firebase_core/example/android/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ subprojects {
2424
project.evaluationDependsOn(':app')
2525
}
2626

27-
task clean(type: Delete) {
27+
tasks.register("clean", Delete) {
2828
delete rootProject.buildDir
2929
}

packages/firebase_core/firebase_core/example/ios/Runner.xcodeproj/project.pbxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
97C146E61CF9000F007C117D /* Project object */ = {
167167
isa = PBXProject;
168168
attributes = {
169-
LastUpgradeCheck = 1300;
169+
LastUpgradeCheck = 1430;
170170
ORGANIZATIONNAME = "The Chromium Authors";
171171
TargetAttributes = {
172172
97C146ED1CF9000F007C117D = {

packages/firebase_core/firebase_core/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1300"
3+
LastUpgradeVersion = "1430"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

packages/firebase_core/firebase_core/example/ios/Runner/Info.plist

+2
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,7 @@
4343
<false/>
4444
<key>CADisableMinimumFrameDurationOnPhone</key>
4545
<true/>
46+
<key>UIApplicationSupportsIndirectInputEvents</key>
47+
<true/>
4648
</dict>
4749
</plist>

packages/firebase_core/firebase_core/ios/Classes/FLTFirebaseCorePlugin.m

-12
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ - (PigeonFirebaseOptions *)optionsFromFIROptions:(FIROptions *)options {
6161
pigeonOptions.projectId = (id)options.projectID ?: [NSNull null];
6262
pigeonOptions.databaseURL = (id)options.databaseURL ?: [NSNull null];
6363
pigeonOptions.storageBucket = (id)options.storageBucket ?: [NSNull null];
64-
pigeonOptions.trackingId = (id)options.trackingID ?: [NSNull null];
6564
pigeonOptions.deepLinkURLScheme = (id)options.deepLinkURLScheme ?: [NSNull null];
66-
pigeonOptions.androidClientId = (id)options.androidClientID ?: [NSNull null];
6765
pigeonOptions.iosBundleId = (id)options.bundleID ?: [NSNull null];
6866
pigeonOptions.iosClientId = (id)options.clientID ?: [NSNull null];
6967
pigeonOptions.appGroupId = (id)options.appGroupID ?: [NSNull null];
@@ -137,21 +135,11 @@ - (void)initializeAppAppName:(nonnull NSString *)appName
137135
options.storageBucket = initializeAppRequest.storageBucket;
138136
}
139137

140-
// kFirebaseOptionsTrackingId
141-
if (![initializeAppRequest.trackingId isEqual:[NSNull null]]) {
142-
options.trackingID = initializeAppRequest.trackingId;
143-
}
144-
145138
// kFirebaseOptionsDeepLinkURLScheme
146139
if (![initializeAppRequest.deepLinkURLScheme isEqual:[NSNull null]]) {
147140
options.deepLinkURLScheme = initializeAppRequest.deepLinkURLScheme;
148141
}
149142

150-
// kFirebaseOptionsAndroidClientId
151-
if (![initializeAppRequest.androidClientId isEqual:[NSNull null]]) {
152-
options.androidClientID = initializeAppRequest.androidClientId;
153-
}
154-
155143
// kFirebaseOptionsIosBundleId
156144
if (![initializeAppRequest.iosBundleId isEqual:[NSNull null]]) {
157145
options.bundleID = initializeAppRequest.iosBundleId;

tests/lib/firebase_options.dart

-4
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ class DefaultFirebaseOptions {
6969
databaseURL:
7070
'https://flutterfire-e2e-tests-default-rtdb.europe-west1.firebasedatabase.app',
7171
storageBucket: 'flutterfire-e2e-tests.appspot.com',
72-
androidClientId:
73-
'406099696497-tvtvuiqogct1gs1s6lh114jeps7hpjm5.apps.googleusercontent.com',
7472
iosClientId:
7573
'406099696497-taeapvle10rf355ljcvq5dt134mkghmp.apps.googleusercontent.com',
7674
iosBundleId: 'io.flutter.plugins.firebase.tests',
@@ -84,8 +82,6 @@ class DefaultFirebaseOptions {
8482
databaseURL:
8583
'https://flutterfire-e2e-tests-default-rtdb.europe-west1.firebasedatabase.app',
8684
storageBucket: 'flutterfire-e2e-tests.appspot.com',
87-
androidClientId:
88-
'406099696497-tvtvuiqogct1gs1s6lh114jeps7hpjm5.apps.googleusercontent.com',
8985
iosClientId:
9086
'406099696497-taeapvle10rf355ljcvq5dt134mkghmp.apps.googleusercontent.com',
9187
iosBundleId: 'io.flutter.plugins.firebase.tests',

0 commit comments

Comments
 (0)