Skip to content

fix(core, windows): make auth, firestore and storage can build in release mode. #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cynthiajoan
Copy link
Collaborator

Description

add packages for release path process in firebase_core/CMakeLists.txt

Related Issues

#11919

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@alexvoina
Copy link

I'm still getting tons of errors:

pubspec.lock plugin versions:

firebase_core:
dependency: transitive
description:
name: firebase_core
sha256: "96607c0e829a581c2a483c658f04e8b159964c3bae2730f73297070bc85d40bb"
url: "https://pub.dev"
source: hosted
version: "2.24.2"
firebase_core_platform_interface:
dependency: transitive
description:
name: firebase_core_platform_interface
sha256: c437ae5d17e6b5cc7981cf6fd458a5db4d12979905f9aafd1fea930428a9fe63
url: "https://pub.dev"
source: hosted
version: "5.0.0"
firebase_core_web:
dependency: transitive
description:
name: firebase_core_web
sha256: d585bdf3c656c3f7821ba1bd44da5f13365d22fcecaf5eb75c4295246aaa83c0
url: "https://pub.dev"
source: hosted
version: "2.10.0"
firebase_storage:
dependency: "direct main"
description:
name: firebase_storage
sha256: "8126e80210c0841a5b8204590b40d6b9e87cded3d342a92833f484a564dcddb3"
url: "https://pub.dev"
source: hosted
version: "11.5.6"
firebase_storage_platform_interface:
dependency: transitive
description:
name: firebase_storage_platform_interface
sha256: "545a3a8edf337850403bb0fa03c8074a53deb87c0107d19755c77a82ce07919e"
url: "https://pub.dev"
source: hosted
version: "5.1.3"
firebase_storage_web:
dependency: transitive
description:
name: firebase_storage_web
sha256: ee6870ff79aa304b8996ba18a4aefe1e8b3fc31fd385eab6574180267aa8d393
url: "https://pub.dev"
source: hosted
version: "3.6.17"

cloud_firestore:
dependency: "direct main"
description:
  name: cloud_firestore
  sha256: cb978c7512624144f24f3d06e4312b2f4ac00b016f2fed62dc8f6d56b8585d78
  url: "https://pub.dev"
source: hosted
version: "4.13.6"

cloud_firestore_platform_interface:
dependency: transitive
description:
name: cloud_firestore_platform_interface
sha256: fa177fa85f7665c76e1ebec252a5b280b4b47612b4d70fe286944814fff1d4f2
url: "https://pub.dev"
source: hosted
version: "6.0.10"
cloud_firestore_web:
dependency: transitive
description:
name: cloud_firestore_web
sha256: d0ebbf0927e627c0d7d2f3177d3b6f0050e5d811c08c2b646b0c746a2b502cb7
url: "https://pub.dev"
source: hosted
version: "3.8.10"

flutter doctor:

[√] Flutter (Channel stable, 3.16.5, on Microsoft Windows [Version 10.0.19045.3693], locale en-US)
• Flutter version 3.16.5 on channel stable at C:\MY_PATH\third-party\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 78666c8dc5 (34 hours ago), 2023-12-19 16:14:14 -0800
• Engine revision 3f3e560236
• Dart version 3.2.3
• DevTools version 2.28.4

[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.1.4)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.1.32407.343
• Windows 10 SDK version 10.0.19041.0

[√] VS Code (version 1.84.2)
• VS Code at C:\MY_PATH\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.78.0

flutter build windows (release) output

LINK : warning LNK4217: symbol '??1bad_cast@std@@UEAA@XZ (public: virtual __cdecl std::bad_cast::~bad_cast(void))' defined in 'cloud_firestore_plugin.lib(messages.g.obj)' is imported by 'cloud_firestore_plugin.lib(cloud_firestore_plugin.obj)' in function '"public: virtual __cdecl std::bad_any_cast::~bad_any_cast(void)" (??1bad_any_cast@std@@UEAA@XZ)' [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] LINK : warning LNK4286: symbol '??1bad_cast@std@@UEAA@XZ (public: virtual __cdecl std::bad_cast::~bad_cast(void))' defined in 'cloud_firestore_plugin.lib(messages.g.obj)' is imported by 'cloud_firestore_plugin.lib(firestore_codec.obj)' [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] cloud_firestore_plugin.lib(cloud_firestore_plugin.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl std::bad_cast::bad_cast(char const *)" (__imp_??0bad_cast@std@@QEAA@PEBD@Z) referenced in function "public: __cdecl std::bad_any_cast::bad_any_cast(void)" (??0bad_any_cast@std@@QEAA@XZ) [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] cloud_firestore_plugin.lib(firestore_codec.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __cdecl std::bad_cast::bad_cast(char const *)" (__imp_??0bad_cast@std@@QEAA@PEBD@Z) [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] cloud_firestore_plugin.lib(cloud_firestore_plugin.obj) : error LNK2001: unresolved external symbol "protected: virtual void __cdecl std::bad_cast::_Doraise(void)const " (?_Doraise@bad_cast@std@@MEBAXXZ) [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] cloud_firestore_plugin.lib(firestore_codec.obj) : error LNK2001: unresolved external symbol "protected: virtual void __cdecl std::bad_cast::_Doraise(void)const " (?_Doraise@bad_cast@std@@MEBAXXZ) [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_app.lib(9517b511b2df07341741fe8d83119943_firebase_app.dir_Release_heartbeat_storage_desktop.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_app.lib(2a9c0070e23347017017220667a5f09e_ssl.dir_Release_encrypted_client_hello.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(ec49100c7e8ab9d550bace2974e79db6_firestore_util.dir_Release_string_format.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(eb538fd19dcffbedfd665e1dfbbc15d8_absl_str_format_internal.dir_Release_arg.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(f629d927b3c258f787fa088466975c44_absl_strings.dir_Release_charconv_bigint.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(1fe95d6838d9909cdf909015eeba18ea_re2.dir_Release_stringpiece.obj) : error LNK2001: unresolved external symbol __std_find_trivial_1 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_auth.lib(d48c2d5c2ee6ee6849b2a8e761eb596c_firebase_auth.dir_Release_auth.obj) : error LNK2001: unresolved external symbol __std_find_trivial_8 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(060e08416dfaa8337f6db6660c103cb2_firestore_core.dir_Release_grpc_connection.obj) : error LNK2001: unresolved external symbol __std_find_trivial_8 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_app.lib(9517b511b2df07341741fe8d83119943_firebase_app.dir_Release_cleanup_notifier.obj) : error LNK2001: unresolved external symbol __std_find_trivial_8 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_app.lib(9df1b499e9d93fa7bea97ae713d33ce7_flatbuffers.dir_Release_idl_parser.obj) : error LNK2001: unresolved external symbol __std_find_trivial_8 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_storage.lib(ec8e84d87ed30ad4d45497f650aa581b_firebase_storage.dir_Release_storage_desktop.obj) : error LNK2001: unresolved external symbol __std_find_trivial_8 [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(1fe95d6838d9909cdf909015eeba18ea_re2.dir_Release_re2.obj) : error LNK2019: unresolved external symbol __std_init_once_link_alternate_names_and_abort referenced in function "public: __cdecl std::_Init_once_completer::~_Init_once_completer(void)" (??1_Init_once_completer@std@@QEAA@XZ) [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(1fe95d6838d9909cdf909015eeba18ea_re2.dir_Release_dfa.obj) : error LNK2001: unresolved external symbol __std_init_once_link_alternate_names_and_abort [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] firebase_firestore.lib(1fe95d6838d9909cdf909015eeba18ea_re2.dir_Release_regexp.obj) : error LNK2001: unresolved external symbol __std_init_once_link_alternate_names_and_abort [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj] C:MY_PROJECT_PATH\build\windows\x64\runner\Release\hiits_studio.exe : fatal error LNK1120: 5 unresolved externals [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj]

when building debug i get 2000 warnings of this type:

firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug__src_core_ext_upbdefs_generated_envoy_extensions_filters_http_rbac_v3_rbac.upbdefs.c.obj) : warning LNK4099: PDB 'grpc.pdb' was not found with 'firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug__src_core_ext_upbdefs_generated_envoy_extensions_filters_http_rbac_v3_rbac.upbdefs.c.obj)' or at 'C:MY_PROJECT_PATH\build\windows\x64\runner\Debug\grpc.pdb'; linking object as if no debug info [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj]
firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug_accesslog.upb.obj) : warning LNK4099: PDB 'grpc.pdb' was not found with 'firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug_accesslog.upb.obj)' or at 'C:MY_PROJECT_PATH\build\windows\x64\runner\Debug\grpc.pdb'; linking object as if no debug info [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj]
firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug_wrappers.upb.obj) : warning LNK4099: PDB 'grpc.pdb' was not found with 'firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug_wrappers.upb.obj)' or at 'C:MY_PROJECT_PATH\build\windows\x64\runner\Debug\grpc.pdb'; linking object as if no debug info [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj]
firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug__src_core_lib_security_authorization_matchers.cc.obj) : warning LNK4099: PDB 'grpc.pdb' was not found with 'firebase_firestore.lib(ea039456823ba76e9082b438a5fcc026_grpc.dir_Debug__src_core_lib_security_authorization_matchers.cc.obj)' or at 'C:MY_PROJECT_PATH\build\windows\x64\runner\Debug\grpc.pdb'; linking object as if no debug info [C:MY_PROJECT_PATH\build\windows\x64\runner\hiits_studio.vcxproj]

@firebase firebase locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants