Fully parameterize default kinds of intrinsic types #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskeith
reviewed
Oct 16, 2018
| } else if (arg == "-r8" || arg == "-fdefault-real-8") { | ||
| defaultKinds.set_defaultRealKind(8); | ||
| } else if (arg == "-i8" || arg == "-fdefault-integer-8") { | ||
| defaultKinds.set_defaultIntegerKind(8); |
There was a problem hiding this comment.
Does it make sense to allow the default real and integer kind to be set independently? Default integer and default real are both supposed to occupy "a single numeric storage unit" so changing one but not the other would violate that.
There was a problem hiding this comment.
The way that these options kind of make sense, at least to me, in those circumstances, is by viewing the expanded default type as occupying two numeric storage units.
tskeith
approved these changes
Oct 16, 2018
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@dd819b4 Reviewed-on: flang-compiler/f18#213 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@10e4a33 Reviewed-on: flang-compiler/f18#213 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@1760b9c Reviewed-on: flang-compiler/f18#213 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@ff7f338 Reviewed-on: flang-compiler/f18#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates old definitions of
DefaultIntegerintype.h. Creates a new object to hold default kinds of intrinsic types and uses it everywhere. Adds options to the development driver program to tweak those defaults. Renamesdft-like names inintrinsics.ccto better names that have been made available. Changes intrinsic function result types to accommodate large arrays even when default INTEGER is small.Also document that
TandFare not supported as extensions.