Structure constructor semantics #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskeith
reviewed
Feb 16, 2019
lib/semantics/mod-file.cc
Outdated
| PutLower(decls_ << ",extends(", details.extends().ToString()) << ')'; | ||
| if (const DerivedTypeSpec * extends{typeSymbol.GetParentTypeSpec()}) { | ||
| PutLower(decls_ << ",extends(", extends->typeSymbol().name().ToString()) | ||
| << ')'; |
There was a problem hiding this comment.
There is an overloading of PutLower that takes a symbol instead of a name:
PutLower(decls_ << ",extends(", extends->typeSymbol()) << ')';
tskeith
reviewed
Feb 16, 2019
lib/semantics/symbol.h
Outdated
| // order. A parent component, if any, appears first in this list. | ||
| std::list<const Symbol *> components_; | ||
| SourceName extends_; | ||
| std::list<SourceName> components_; |
There was a problem hiding this comment.
componentNames_ might be a better name for this field. In the functions OrderComponents() and GetParentComponent(), "component" means component symbol, not name.
tskeith
reviewed
Feb 17, 2019
lib/semantics/symbol.cc
Outdated
| if (symbol.test(Symbol::Flag::ParentComp)) { | ||
| CHECK(result.empty()); | ||
| const DerivedTypeSpec &spec{ | ||
| *symbol.get<ObjectEntityDetails>().type()->AsDerived()}; |
There was a problem hiding this comment.
Since you're assuming the type is a derived type, you could use symbol.get<ObjectEntityDetails>().type()->derivedTypeSpec(). It asserts it is a derived type and returns a reference.
Maybe we shouldn't have both AsDerived() and derivedTypeSpec().
There was a problem hiding this comment.
Thanks; fixed it here and in one other place that I found.
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@7131a2f Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…omponent list Original-commit: flang-compiler/f18@1515022 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@9d60038 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@47986f0 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@03944d5 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@b0a574f Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@156791b Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@fc807bf Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@6146957 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@d90d5d9 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@e66ef36 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@8a081e8 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@e6178b2 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@03fcb58 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@17dc735 Reviewed-on: flang-compiler/f18#287 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@7662121 Reviewed-on: flang-compiler/f18#287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantic analysis, representation, and folding of structure constructors. The semantic analysis is performed during expression semantics, so that the code will be in the right place after generic function call resolution is implemented.
Constants got a lot of working over, and constant Character objects are now in their own template specialization. Constant character array elements are no longer distinct std::strings, but are instead all packed into one string in Fortran element order, anticipating their use in folding of transformational intrinsics. (Constant derived type values are not yet packed in storage.)
Some further work on array constructors was done after taking a few passes with this code over some regression test suites. A language extension implemented by PGI and another compiler was discovered and now supported regarding character array constructors with distinct lengths on their character literals.
Some TODOs remain with structure and array constructors with regard to type conformance checking; that'll come next week.