This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Implementing TextScaler for nonlinear text scaling (#42062)" #44907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
reviewed
Aug 21, 2023
|
|
||
| verify(executor).send(eq("flutter/settings"), messageCaptor.capture(), isNull()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add a test with minSdk = 33 that will eventually exercise the api 34 code or at minimum a todo with link to a bug in this file to add a tests once api 34 is available against roboletric.
There was a problem hiding this comment.
Added a TODO that points to flutter/flutter#128825
a415da5 to
50352d7
Compare
reidbaker
approved these changes
Aug 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2023
…133010) flutter/engine@e5929d8...5a292e4 2023-08-21 [email protected] Roll Fuchsia Linux SDK from lDn2QLh1I7rtNu01y... to RVhmZNTYsaIiTyjwP... (flutter/engine#44932) 2023-08-21 [email protected] Roll Skia from da6b74568ece to 40442138ec94 (3 revisions) (flutter/engine#44931) 2023-08-21 [email protected] Reland "Implementing TextScaler for nonlinear text scaling (#42062)" (flutter/engine#44907) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lDn2QLh1I7rt to RVhmZNTYsaIi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…2062)" (flutter#44907) The original PR crashes because of a JNI signature mismatch (`(FJ)F` -> `(FI)F`). Update the signature in flutter@a415da5 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR crashes because of a JNI signature mismatch (
(FJ)F->(FI)F). Update the signature in a415da5Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.