-
Notifications
You must be signed in to change notification settings - Fork 302
generateGitPropertiesFilename property path is always relative to the project #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related to #81, right? Though it's working for me with 2.1.8. Could you give an example if really fails? |
Pull requesting into this one to show the error would be great: https://github.com/ktoso/git-commit-id-debugging |
hey there, are you still interested in this? Will close as "can't reproduce" otherwise. :-) |
I'm not using this option now because when I tried two months ago I was getting the behavior described, the other bug looks related so maybe it is fixed now. |
Would be great if you could help checking this. I'd like to close or fix this one :) |
I noticed this also. You'll see it try to save to a file with C:\ twice by default due to project.basedir being a fully qualified path and this always enforcing a relative path. Quickly resolved by not using the default value and not using any absolute paths (as in your debugging project). |
I have that issue too. <plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<version>2.1.10</version>
<executions>
<execution>
<phase>initialize</phase>
<goals>
<goal>revision</goal>
</goals>
</execution>
</executions>
<configuration>
<generateGitPropertiesFile>true</generateGitPropertiesFile>
<generateGitPropertiesFilename>src/main/resources/git.properties</generateGitPropertiesFilename>
<verbose>true</verbose>
<gitDescribe>
<dirty>true</dirty>
</gitDescribe>
</configuration>
</plugin> |
This problem should be fixed and merged by now. See: #125 Thanks for reporting and helpful answers! Feel free to reopen the issue if still broken. |
Try something like
${project.build.directory}/${project.build.finalName}/WEB-INF/classes/git.properties
for generateGitPropertiesFilename, it'll create home/<...>/target/<...>/WEB-INF/classes/git.properties in your project folder.
The text was updated successfully, but these errors were encountered: