Added possibility to specify encoding for generated git.properties file #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.json file. If no encoding is configured, platform encoding will be used as before. Resolves git-commit-id#130
|
Hello @ffriedrich, as discussed in #130 (comment), let's just make sure we use UTF-8 everywhere instead of exposing another option (this plugin has way too many plugins already :-)). Thanks a lot for digging into this, awaiting an updated PR! |
|
Ok, I have updated the pull request and set the encoding to UTF-8. |
| File gitPropsFile = craftPropertiesOutputFile(base, propertiesFilename); | ||
| try { | ||
| Files.createParentDirs(gitPropsFile); | ||
|
|
||
| fileWriter = new FileWriter(gitPropsFile); | ||
| outputWriter = new OutputStreamWriter(new FileOutputStream(gitPropsFile), Charset.forName("UTF-8")); |
There was a problem hiding this comment.
Please use guava's Charsets.UTF_8 instead of strings here :)
|
Looks good in general, would you mind fixing the one issue I pointed out and squashing this into one commit? I'll merge once I get internet again :-) |
ktoso
added a commit
that referenced
this pull request
Sep 23, 2014
Added possibility to specify encoding for generated git.properties file
|
Got hotel internet working, let's merge this :-) |
|
cool, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and git.json file.
If no encoding is configured, platform encoding will be used as before.
Resolves #130