This repository was archived by the owner on Jun 9, 2020. It is now read-only.
Use iframe for Chromium perf tests to remove --disable-web-security #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity
Previously:
(a) util_performance_test.js in Blink runs performance tests using
(b) pywebsocket's scripts,
but this required --disable-web-security for cross-origin workers
because (a) and (b) have different origins.
We change this so that:
(a) util_performance_test.js creates
(c) <iframe> with src=pywebsocket's example/*_iframe.html that runs
the performance tests on the iframe using
(b) pywebsocket's scripts.
Because (b) and (c) have the same origin (but (a) has a different origin),
Tests are run in the same-origin while we have an cross-origin iframe.
This CL adds pywebsocket-side iframe HTML/JavaScript files for (b) and (c).
[1] pywebsocket-side: This CL.
[2] Chromium-side: https://codereview.chromium.org/1521943002/
BUG=https://code.google.com/p/chromium/issues/detail?id=567533
|
tyoshino, could you take a look? |
|
Could you please fix the OP? It contains HTML tags and entity references. Copied from https://codereview.chromium.org/1521943002 or somewhere? |
|
Fixed. (it was generated from the commit message and was corrupt because it was interpreted as markdown. Fixed by adding a markdown annotation) |
|
lgtm 4f10526 |
hiroshige-g
added a commit
that referenced
this pull request
Dec 15, 2015
Use iframe for Chromium perf tests to remove --disable-web-security
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
(a) util_performance_test.js in Blink runs performance tests using
(b) pywebsocket's scripts,
but this required --disable-web-security for cross-origin workers
because (a) and (b) have different origins.
We change this so that:
(a) util_performance_test.js creates
(c)
<iframe>with src=pywebsocket's example/*_iframe.html that runsthe performance tests on the iframe using
(b) pywebsocket's scripts.
Because (b) and (c) have the same origin (but (a) has a different origin),
Tests are run in the same-origin while we have an cross-origin iframe.
This CL adds pywebsocket-side iframe HTML/JavaScript files for (b) and (c).
[1] pywebsocket-side: This CL.
[2] Chromium-side: https://codereview.chromium.org/1521943002/
BUG=https://code.google.com/p/chromium/issues/detail?id=567533