This repository was archived by the owner on Sep 26, 2023. It is now read-only.
chore: Add SonarCloud support #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
approved these changes
Jan 28, 2022
| uses: actions/cache@v1 | ||
| with: | ||
| path: ~/.sonar/cache | ||
| key: ${{ runner.os }}-sonar |
There was a problem hiding this comment.
Is this correct? It will never be recached once done? In another repo, I see
key: ${{ runner.os }}-sonar-${{ steps.date.outputs.date }}
which looks more reasonable. (However, I don't understand restore-keys, so I may be missing something.)
There was a problem hiding this comment.
That's the default with the issue of potentially having a very large cache over the long term. For now, I think we can just proceed with the default.
Co-authored-by: Chanseok Oh <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarCloud provides code coverage and static code quality analysis.
https://sonarcloud.io/project/overview?id=googleapis_gax-java