fix(spanner): unnecessary string formatting fixes (#10736)

* fix(spanner): incorrect use of sprintf method

* fix(spanner): unnecessary use of fmt.Sprintf

---------

Co-authored-by: rahul2393 <[email protected]>

Author: egonelbre

spanner/errors.go

@@ -82,7 +82,7 @@ func (e *TransactionOutcomeUnknownError) Unwrap() error { return e.err }
 // Error implements error.Error.
 func (e *Error) Error() string {
 	if e == nil {
-		return fmt.Sprintf("spanner: OK")
+		return "spanner: OK"
 	}
 	code := ErrCode(e)
 	if e.additionalInformation == "" {

spanner/integration_test.go

@@ -6280,29 +6280,29 @@ func blackholeOrAllowDirectPath(t *testing.T, blackholeDP bool) {
 		if blackholeDP {
 			cmdRes := exec.Command("bash", "-c", blackholeDpv4Cmd)
 			out, _ := cmdRes.CombinedOutput()
-			t.Logf(string(out))
+			t.Log(string(out))
 		} else {
 			cmdRes := exec.Command("bash", "-c", allowDpv4Cmd)
 			out, _ := cmdRes.CombinedOutput()
-			t.Logf(string(out))
+			t.Log(string(out))
 		}
 		return
 	}
 	// DirectPath supports both ipv4 and ipv6
 	if blackholeDP {
 		cmdRes := exec.Command("bash", "-c", blackholeDpv4Cmd)
 		out, _ := cmdRes.CombinedOutput()
-		t.Logf(string(out))
+		t.Log(string(out))
 		cmdRes = exec.Command("bash", "-c", blackholeDpv6Cmd)
 		out, _ = cmdRes.CombinedOutput()
-		t.Logf(string(out))
+		t.Log(string(out))
 	} else {
 		cmdRes := exec.Command("bash", "-c", allowDpv4Cmd)
 		out, _ := cmdRes.CombinedOutput()
-		t.Logf(string(out))
+		t.Log(string(out))
 		cmdRes = exec.Command("bash", "-c", allowDpv6Cmd)
 		out, _ = cmdRes.CombinedOutput()
-		t.Logf(string(out))
+		t.Log(string(out))
 	}
 }
 

spanner/session_test.go

@@ -371,7 +371,7 @@ func TestSessionLeak(t *testing.T) {
 	if single.sh.stack == nil && !isMultiplexEnabled {
 		t.Fatalf("Missing stacktrace from session handle")
 	}
-	stack := fmt.Sprintf("%s", single.sh.stack)
+	stack := string(single.sh.stack)
 	testMethod := "TestSessionLeak"
 	if !strings.Contains(stack, testMethod) && !isMultiplexEnabled {
 		t.Fatalf("Stacktrace does not contain '%s'\nGot: %s", testMethod, stack)

spanner/spannertest/integration_test.go

@@ -107,7 +107,7 @@ func makeClient(t *testing.T) (*spanner.Client, *dbadmin.DatabaseAdminClient, *v
 	// Don't use SPANNER_EMULATOR_HOST because we need the raw connection for
 	// the database admin client anyway.
 
-	t.Logf("Using in-memory fake Spanner DB")
+	t.Log("Using in-memory fake Spanner DB")
 	srv, err := NewServer("localhost:0")
 	if err != nil {
 		t.Fatalf("Starting in-memory fake: %v", err)

spanner/timestampbound.go

@@ -174,7 +174,7 @@ func ReadTimestamp(t time.Time) TimestampBound {
 func (tb TimestampBound) String() string {
 	switch tb.mode {
 	case strong:
-		return fmt.Sprintf("(strong)")
+		return "(strong)"
 	case exactStaleness:
 		return fmt.Sprintf("(exactStaleness: %s)", tb.d)
 	case maxStaleness: