Skip to content

Commit ca8d3cb

Browse files
authored
feat(spanner): fix falkiness (#8977)
1 parent b2db89e commit ca8d3cb

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

spanner/client_test.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -1047,18 +1047,18 @@ func TestClient_ReadOnlyTransaction_WhenMultipleOperations_SessionLastUseTimeSho
10471047
MaxOpened: 1,
10481048
InactiveTransactionRemovalOptions: InactiveTransactionRemovalOptions{
10491049
actionOnInactiveTransaction: WarnAndClose,
1050-
idleTimeThreshold: 30 * time.Millisecond,
1050+
idleTimeThreshold: 300 * time.Millisecond,
10511051
},
10521052
},
10531053
})
10541054
defer teardown()
10551055
server.TestSpanner.PutExecutionTime(MethodExecuteStreamingSql,
10561056
SimulatedExecutionTime{
1057-
MinimumExecutionTime: 20 * time.Millisecond,
1057+
MinimumExecutionTime: 200 * time.Millisecond,
10581058
})
10591059
server.TestSpanner.PutExecutionTime(MethodStreamingRead,
10601060
SimulatedExecutionTime{
1061-
MinimumExecutionTime: 20 * time.Millisecond,
1061+
MinimumExecutionTime: 200 * time.Millisecond,
10621062
})
10631063
ctx := context.Background()
10641064
p := client.idleSessions
@@ -1090,11 +1090,11 @@ func TestClient_ReadOnlyTransaction_WhenMultipleOperations_SessionLastUseTimeSho
10901090
t.Fatalf("Session lastUseTime times should not be equal")
10911091
}
10921092

1093-
if (time.Now().Sub(sessionPrevLastUseTime)).Milliseconds() < 40 {
1094-
t.Fatalf("Expected session to be checkedout for more than 40 milliseconds")
1093+
if (time.Now().Sub(sessionPrevLastUseTime)).Milliseconds() < 400 {
1094+
t.Fatalf("Expected session to be checkedout for more than 400 milliseconds")
10951095
}
1096-
if (time.Now().Sub(sessionCheckoutTime)).Milliseconds() < 40 {
1097-
t.Fatalf("Expected session to be checkedout for more than 40 milliseconds")
1096+
if (time.Now().Sub(sessionCheckoutTime)).Milliseconds() < 400 {
1097+
t.Fatalf("Expected session to be checkedout for more than 400 milliseconds")
10981098
}
10991099
// force run task to clean up unexpected long-running sessions whose lastUseTime >= 3sec.
11001100
// The session should not be cleaned since the latest operation on the transaction has updated the lastUseTime.

0 commit comments

Comments
 (0)