Skip to content

Storage: un-skip system tests for 'Bucket.generate_signed_url' #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tseaver opened this issue Apr 1, 2019 · 3 comments
Closed

Storage: un-skip system tests for 'Bucket.generate_signed_url' #7625

tseaver opened this issue Apr 1, 2019 · 3 comments
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. backend testing type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Apr 1, 2019

Follow-on from PR #7460.

Currently, the GCS back-end has a bug for signed URLs against buckets: unlike blobs, which expect an appropriately-capitalized X-Goog-Signature query parameter, buckets want that parameter lower-cased. The system tests for signed bucket URLs are thus skipped in the PR, which is likely to merge before a back-end fix rolls out.

Once the fix is rolled up, remove the skips.
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing type: process A process-related concern. May include testing, release, or the like. labels Apr 1, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Apr 1, 2019

/cc @frankyn

@tseaver tseaver added the backend label Apr 1, 2019
@tseaver tseaver mentioned this issue Apr 1, 2019
Merged
4 tasks
@frankyn
Copy link
Contributor

frankyn commented Apr 4, 2019

This is unblocked and can now be unskipped.

@tseaver tseaver changed the title Storage: remove skipped system tests for 'Bucket.generate_signed_url' Storage: un-skip system tests for 'Bucket.generate_signed_url' Apr 16, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Apr 17, 2019

8f2e13f in PR #7460 removes the skips.

@tseaver tseaver closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. backend testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @frankyn