Skip to content

Storage: deprecate 'fields' arg to 'Bucket.list_blobs'. #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Storage: deprecate 'fields' arg to 'Bucket.list_blobs'. #7897

wants to merge 2 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 8, 2019

Closes #7875.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 8, 2019
@tseaver tseaver requested a review from frankyn May 8, 2019 15:56
@tseaver tseaver requested a review from crwilcox as a code owner May 8, 2019 15:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@frankyn
Copy link
Contributor

frankyn commented May 8, 2019 •
edited
Loading

Thanks for looping me in @tseaver. This field isn't deprecated and documented here instead:
https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance

The field is actively used by the google-cloud-java library for Storage for metadata field selection.

I'll file a bug against cloud documentation on surfacing the field in Objects.List and other ref docs.

INTERNAL BUG: 132247394

@tseaver tseaver mentioned this pull request May 8, 2019
Closed
@xmedeko
Copy link

xmedeko commented May 8, 2019

@tseaver beside the warning, the deprecation should be in the method doc, too. (If this change is accepted.)

@tseaver
Copy link
Contributor Author

tseaver commented May 8, 2019

@frankyn OK, then do you think we need to add a method which makes fields useful, e.g. Bucket.list_blob_info? Using it at all breaks Bucket.list_blobs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 15, 2019
@tseaver tseaver mentioned this pull request May 17, 2019
Merged
@tseaver
Copy link
Contributor Author

tseaver commented May 17, 2019

Superseded by #8023.

@tseaver tseaver closed this May 17, 2019
@tseaver tseaver deleted the 7875-storage-deprecate-fields-arg-to-list_blobs branch May 17, 2019 20:05
tseaver added a commit that referenced this pull request May 18, 2019
@tseaver
Improve docs for 'fields' argument to 'Bucket.list_blobs'. (#8023)
4166ddb 
Closes #7875.

Supersedes #7897.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn Awaiting requested review from frankyn

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Bucket.list_blobs fields param doc
5 participants
@tseaver @frankyn @xmedeko @googlebot @yoshi-automation