-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Storage: add 'google.cloud.storage.hmac_keys.HMACKeyMetadata' resource class. #8041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tseaver
merged 2 commits into
googleapis:storage-add-hmac-key-support-feature
from
tseaver:7851-storage-add-hmac_key_metadata
May 21, 2019
Merged
Storage: add 'google.cloud.storage.hmac_keys.HMACKeyMetadata' resource class. #8041
tseaver
merged 2 commits into
googleapis:storage-add-hmac-key-support-feature
from
tseaver:7851-storage-add-hmac_key_metadata
May 21, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Unrelated system test flake. I reopened #7384. |
jkwlui
approved these changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved w/ nits
tseaver
added a commit
that referenced
this pull request
Jun 19, 2019
tseaver
added a commit
that referenced
this pull request
Jun 26, 2019
tseaver
added a commit
that referenced
this pull request
Jul 2, 2019
tseaver
added a commit
that referenced
this pull request
Jul 2, 2019
tseaver
added a commit
that referenced
this pull request
Jul 9, 2019
tseaver
added a commit
that referenced
this pull request
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkwlui Note that this PR targets the
storage-add-hmac-key-support-feature
branch, which will be merged tomaster
once all the steps in #7851 are completed.Toward #7851.