-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Storage: add HMAC key support #8430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b07516
to
f5cbf13
Compare
@jkwlui Working on system tests: the POST to Update: I tweaked the system tests to use the client's credentials to discover the service account email, rather than querying for one. They now pass. |
2cdf630
to
e1b14af
Compare
Rebased to deal with out-of-date madness. |
e1b14af
to
e15ddac
Compare
Storage Kokoro job fails due to flaky systest, #8552. |
4386da1
to
6cc2fc3
Compare
Force-pushed to pick up the systest fix from #8617. |
Ugh, Storage failure due to #8455. |
6cc2fc3
to
928959d
Compare
Rebased again to pick up systest fix from #8620. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please hold off from merging until the feature is off whitelist :)
@jkwlui No worries. Please ping this PR when the feature is off whitelist. |
Per discussion with @frankyn, I plan to add optional |
Further discussion leads to the need for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tseaver LGTM. Please merge when ready.
@jkwlui This PR is for merging the HMAC keys feature branch to
master
: you have already-reviewed the changes in PRs #8041, #8043, and #8045.I still need to:
HMACKeyMetadata
resources.Closes #7851.