Storage: Make 'Blob.bucket' a readonly property. #9113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankyn
reviewed
Aug 27, 2019
tswast
reviewed
Aug 27, 2019
| def bucket(self): | ||
| """Bucket which contains the object. | ||
|
|
||
| :rtype: :class:`~google.cloud.storage.bucket.Bucket` |
There was a problem hiding this comment.
Please use Google-style docstrings on new methods.
There was a problem hiding this comment.
Seems cleaner to make that a task to convert whole modules.
There was a problem hiding this comment.
I am happy if it matches the file in which it is added. Agree that we likely have a backlog task to do this though.
|
Unit test failures due to yesterday's |
crwilcox
approved these changes
Aug 27, 2019
| def bucket(self): | ||
| """Bucket which contains the object. | ||
|
|
||
| :rtype: :class:`~google.cloud.storage.bucket.Bucket` |
There was a problem hiding this comment.
I am happy if it matches the file in which it is added. Agree that we likely have a backlog task to do this though.
tswast
approved these changes
Aug 27, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9107.