-
Notifications
You must be signed in to change notification settings - Fork 127
feat: Allow passing autodetect_schema on table update #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow passing autodetect_schema on table update #2661
Conversation
@alvarowolfx seems like you might be a suggested reviewer here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good on my end @emkornfield, but I'd ask @Neenu1995 for some Java specific review.
@shollyman could you take a look in place of Neenu? This change is to help a customer resolve an issue they are seeing. |
Please also add IT tests to verify the functionality. |
@Neenu1995 I don't appear to have access to the test buckets to verify a unit test. I can push what I think it likely a working unit test but would likely need your help to verify. Is there some other way I can formulate a unit test without access to the buckets? |
Hi @emkornfield, Feel free to add the tests to the PR. We can help with the verification. |
244cca0
to
6a19a9e
Compare
@Neenu1995 added a first stab at an integration test. |
|
Two test failing :
|
@Neenu1995 got integration test work (at least kokoro seems happy). |
Thanks @emkornfield. LGTM. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: