Skip to content

Commit bd873bc

Browse files
authored
fix: remove tracking latency from channel priming requests (#1082)
Created a callable that will not publish latency from channel priming to client metrics.
1 parent a9c9002 commit bd873bc

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java

+19-5
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package com.google.cloud.bigtable.data.v2.stub;
1717

18-
import static com.google.cloud.bigtable.data.v2.models.Filters.FILTERS;
19-
2018
import com.google.api.core.ApiFuture;
2119
import com.google.api.core.BetaApi;
2220
import com.google.api.gax.core.FixedCredentialsProvider;
@@ -25,7 +23,11 @@
2523
import com.google.api.gax.grpc.GrpcTransportChannel;
2624
import com.google.api.gax.rpc.FixedTransportChannelProvider;
2725
import com.google.auth.Credentials;
28-
import com.google.cloud.bigtable.data.v2.models.Query;
26+
import com.google.bigtable.v2.ReadRowsRequest;
27+
import com.google.bigtable.v2.RowFilter;
28+
import com.google.bigtable.v2.RowSet;
29+
import com.google.bigtable.v2.TableName;
30+
import com.google.cloud.bigtable.data.v2.models.DefaultRowAdapter;
2931
import com.google.cloud.bigtable.data.v2.models.Row;
3032
import com.google.common.base.Preconditions;
3133
import com.google.common.collect.ImmutableList;
@@ -144,8 +146,20 @@ private void sendPrimeRequests(ManagedChannel managedChannel) throws IOException
144146
// Prime all of the table ids in parallel
145147
for (String tableId : tableIds) {
146148
ApiFuture<Row> f =
147-
stub.readRowCallable()
148-
.futureCall(Query.create(tableId).rowKey(PRIMING_ROW_KEY).filter(FILTERS.block()));
149+
stub.createReadRowsRawCallable(new DefaultRowAdapter())
150+
.first()
151+
.futureCall(
152+
ReadRowsRequest.newBuilder()
153+
.setTableName(
154+
TableName.format(
155+
primingSettings.getProjectId(),
156+
primingSettings.getInstanceId(),
157+
tableId))
158+
.setAppProfileId(primingSettings.getAppProfileId())
159+
.setRows(RowSet.newBuilder().addRowKeys(PRIMING_ROW_KEY).build())
160+
.setFilter(RowFilter.newBuilder().setBlockAllFilter(true).build())
161+
.setRowsLimit(1)
162+
.build());
149163

150164
primeFutures.put(tableId, f);
151165
}

0 commit comments

Comments
 (0)