-
Notifications
You must be signed in to change notification settings - Fork 97
feat: add BigtableDataClientFactory to create lightweight data clients #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BigtableDataClientFactory to create lightweight data clients #112
Conversation
The new factory allows users to construct a single heavy factory object that can create many lightweight clients. This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles
@tonytanger Can you take a look as well? I want to make sure this doesn't conflict with your channel refresh work |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
============================================
+ Coverage 81.33% 81.74% +0.41%
- Complexity 937 952 +15
============================================
Files 95 97 +2
Lines 5850 5927 +77
Branches 325 327 +2
============================================
+ Hits 4758 4845 +87
+ Misses 916 904 -12
- Partials 176 178 +2
Continue to review full report at Codecov.
|
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactory.java
Show resolved
Hide resolved
LGTM. Don't think primechannel and this will conflict. |
The new factory allows users to construct a single heavy factory object that can create many lightweight clients.
This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles