chore: googleapis updates #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 458022604 Source-Link: googleapis/googleapis@e5507fc Source-Link: https://github.com/googleapis/googleapis-gen/commit/2c26a744087ad06367adb44649c93b772f97cc24 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmMyNmE3NDQwODdhZDA2MzY3YWRiNDQ2NDljOTNiNzcyZjk3Y2MyNCJ9
1e17398 to
9fe219d
Compare
igorbernstein2
approved these changes
Jun 29, 2022
Comment on lines
161
to
176
| int nonStaticFields = 0; | ||
| List<String> nonStaticFields = new ArrayList<>(); | ||
| for (Field field : BigtableTableAdminStubSettings.class.getDeclaredFields()) { | ||
| if (!Modifier.isStatic(field.getModifiers())) { | ||
| nonStaticFields++; | ||
| nonStaticFields.add(field.getName()); | ||
| } | ||
| } | ||
| // failure will signal about adding a new settings property | ||
| assertThat(SETTINGS_LIST.length).isEqualTo(nonStaticFields); | ||
| List<String> sortedSettingsList = Arrays.stream(SETTINGS_LIST).sorted().collect(Collectors.toList()); | ||
| List<String> sortedNonStaticFields = nonStaticFields.stream().sorted().collect(Collectors.toList()); | ||
| assertThat(sortedSettingsList).isEqualTo(sortedNonStaticFields); |
There was a problem hiding this comment.
I think this would be cleaner
List<String> declaredFieldNames = Arrays.stream(BigtableTableAdminStubSettings.class.getDeclaredFields())
.filter(f -> Modifier.isStatic(f.getModifiers()))
.map(Field::toString)
.collect(Collectors.toList());
assertThat(declaredFieldNames).containsExactlyElementsIn(SETTINGS_LIST);
mpeddada1
pushed a commit
that referenced
this pull request
Jul 18, 2022
BEGIN_COMMIT_OVERRIDE feat(generated): Cloud Bigtable Undelete Table service and message proto files feat(generated): Add storage_utilization_gib_per_node to Autoscaling target END_COMMIT_OVERRIDE - [ ] Regenerate this pull request now. PiperOrigin-RevId: 458022604 Source-Link: googleapis/googleapis@e5507fc Source-Link: googleapis/googleapis-gen@2c26a74 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmMyNmE3NDQwODdhZDA2MzY3YWRiNDQ2NDljOTNiNzcyZjk3Y2MyNCJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(generated): Cloud Bigtable Undelete Table service and message proto files
feat(generated): Add storage_utilization_gib_per_node to Autoscaling target
END_COMMIT_OVERRIDE
PiperOrigin-RevId: 458022604
Source-Link: googleapis/googleapis@e5507fc
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2c26a744087ad06367adb44649c93b772f97cc24
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmMyNmE3NDQwODdhZDA2MzY3YWRiNDQ2NDljOTNiNzcyZjk3Y2MyNCJ9