Skip to content

chore(deps): add grpc-google-common-protos to the deps bom #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

igorbernstein2
Copy link
Contributor

It's not used by this client, but this client uses proto-google-common-protos,
and the hbase adapter uses grpc-google-common-protos. So we will use the deps
bom to align the 2. Ideally we would use google-common-protos-bom, but that doesn't
exists

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

It's not used by this client, but this client uses proto-google-common-protos,
and the hbase adapter uses grpc-google-common-protos. So we will use the deps
bom to align the 2. Ideally we would use google-common-protos-bom, but that doesn't
exists
@igorbernstein2 igorbernstein2 requested a review from kolea2 January 9, 2020 18:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #144 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
- Coverage     81.74%   81.72%   -0.02%     
  Complexity      952      952              
============================================
  Files            97       97              
  Lines          5927     5927              
  Branches        327      327              
============================================
- Hits           4845     4844       -1     
- Misses          904      905       +1     
  Partials        178      178
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60% <0%> (-0.87%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7082b...bb9f18a. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit 2ea6704 into googleapis:master Jan 9, 2020
@igorbernstein2 igorbernstein2 deleted the bom-fixes-2 branch January 9, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants