-
Notifications
You must be signed in to change notification settings - Fork 97
chore: remove duplicate deps (error_prone & autovalue) from bigtable specific pom #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove duplicate deps (error_prone & autovalue) from bigtable specific pom #742
Conversation
…specific pom google-shared-config already has provisions for autovalue & error_prone. No need for us to track it separately. This will remove auto-value-annotations from the compile path and into annotation processor path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the google-cloud-bigtable/EnableAutoValue.txt file for?
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
============================================
- Coverage 83.63% 83.57% -0.07%
- Complexity 1008 1026 +18
============================================
Files 106 106
Lines 6045 6125 +80
Branches 392 413 +21
============================================
+ Hits 5056 5119 +63
- Misses 786 804 +18
+ Partials 203 202 -1 Continue to review full report at Codecov.
|
Apparently its used to inject AutoValue into the annotation processor? |
google-shared-config already has provisions for autovalue & error_prone. No need for us to track it separately.
This will remove auto-value-annotations from the compile path and into annotation processor path.