Skip to content

chore: remove duplicate deps (error_prone & autovalue) from bigtable specific pom #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

igorbernstein2
Copy link
Contributor

google-shared-config already has provisions for autovalue & error_prone. No need for us to track it separately.
This will remove auto-value-annotations from the compile path and into annotation processor path.

…specific pom

google-shared-config already has provisions for autovalue & error_prone. No need for us to track it separately.
This will remove auto-value-annotations from the compile path and into annotation processor path.
@igorbernstein2 igorbernstein2 requested review from a team as code owners April 20, 2021 16:02
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Apr 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the google-cloud-bigtable/EnableAutoValue.txt file for?

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #742 (cb6ccd2) into master (cfdd0cd) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #742      +/-   ##
============================================
- Coverage     83.63%   83.57%   -0.07%     
- Complexity     1008     1026      +18     
============================================
  Files           106      106              
  Lines          6045     6125      +80     
  Branches        392      413      +21     
============================================
+ Hits           5056     5119      +63     
- Misses          786      804      +18     
+ Partials        203      202       -1     
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 92.64% <0.00%> (-1.39%) 39.00% <0.00%> (ø%)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.83% <0.00%> (-0.82%) 14.00% <0.00%> (ø%)
.../cloud/bigtable/data/v2/stub/GrpcBigtableStub.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...oud/bigtable/data/v2/models/DefaultRowAdapter.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
...d/bigtable/data/v2/stub/SampleRowKeysCallable.java 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
.../admin/v2/stub/EnhancedBigtableTableAdminStub.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...a/v2/stub/readrows/ReadRowsBatchingDescriptor.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
.../stub/mutaterows/MutateRowsBatchingDescriptor.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...bigtable/admin/v2/BigtableInstanceAdminClient.java 99.15% <0.00%> (+0.04%) 46.00% <0.00%> (+2.00%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 97.70% <0.00%> (+0.04%) 23.00% <0.00%> (ø%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfdd0cd...cb6ccd2. Read the comment docs.

@igorbernstein2
Copy link
Contributor Author

What's the google-cloud-bigtable/EnableAutoValue.txt file for?

Apparently its used to inject AutoValue into the annotation processor?
https://github.com/googleapis/java-shared-config/blob/51c9f68ff1736761b21c921f078ab2c8675ff268/pom.xml#L758

@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1d1db7e into googleapis:master Apr 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants