chore: Ignore gapic settings for all streaming RPCs #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prepare for upcoming changes that will move simple retries to gRPC. When this happens we want to retain retry settings at the client level, so they are copied into the manual settings wrapper. See cl/277568516 for more details
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
============================================
+ Coverage 81.29% 81.31% +0.02%
Complexity 937 937
============================================
Files 95 95
Lines 5842 5849 +7
Branches 325 325
============================================
+ Hits 4749 4756 +7
Misses 917 917
Partials 176 176
Continue to review full report at Codecov.
|
kolea2
reviewed
Nov 11, 2019
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Show resolved
Hide resolved
kolea2
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for upcoming changes that will move simple retries to gRPC.
When this happens we want to retain retry settings at the client level, so they are copied into the manual settings wrapper.
See cl/277568516 for more details