-
Notifications
You must be signed in to change notification settings - Fork 97
chore: cloud-rad doc generation #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
============================================
+ Coverage 83.13% 83.46% +0.32%
Complexity 1314 1314
============================================
Files 114 114
Lines 7803 7806 +3
Branches 418 446 +28
============================================
+ Hits 6487 6515 +28
- Misses 1033 1036 +3
+ Partials 283 255 -28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eaball35! Can you confirm that running the updated mvn command works and generates properly with the excluded classes?
Yes I triggered off this commit and was able to successfully generate cloud-rad docs without the excluded classes included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one question
Fixes b/179935006
Due to the way v1 html javadocs are currently configured - we can't produce docs for cloud-rad in exactly the same manner as other java repos. This allows us to generate for cloud-rad (with excluded classes) without changing what we're doing with current doc generation yet.