Skip to content

chore: cloud-rad doc generation #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021
Merged

chore: cloud-rad doc generation #794

merged 2 commits into from
May 5, 2021

Conversation

eaball35
Copy link
Contributor

@eaball35 eaball35 commented May 3, 2021

Fixes b/179935006

Due to the way v1 html javadocs are currently configured - we can't produce docs for cloud-rad in exactly the same manner as other java repos. This allows us to generate for cloud-rad (with excluded classes) without changing what we're doing with current doc generation yet.

@eaball35 eaball35 requested review from a team as code owners May 3, 2021 20:24
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/release/publish_javadoc11.sh

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2021
@eaball35 eaball35 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #794 (b1f6e35) into master (d293585) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #794      +/-   ##
============================================
+ Coverage     83.13%   83.46%   +0.32%     
  Complexity     1314     1314              
============================================
  Files           114      114              
  Lines          7803     7806       +3     
  Branches        418      446      +28     
============================================
+ Hits           6487     6515      +28     
- Misses         1033     1036       +3     
+ Partials        283      255      -28     
Impacted Files Coverage Δ Complexity Δ
.../bigtable/admin/v2/models/RestoredTableResult.java 66.66% <0.00%> (-8.34%) 2.00% <0.00%> (ø%)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.83% <0.00%> (ø) 14.00% <0.00%> (ø%)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 97.13% <0.00%> (+0.01%) 32.00% <0.00%> (ø%)
.../bigtable/admin/v2/models/RestoreTableRequest.java 82.85% <0.00%> (+0.50%) 10.00% <0.00%> (ø%)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 80.43% <0.00%> (+3.91%) 95.00% <0.00%> (ø%)
...igtable/admin/v2/BaseBigtableTableAdminClient.java 82.78% <0.00%> (+5.04%) 123.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d293585...b1f6e35. Read the comment docs.

Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eaball35! Can you confirm that running the updated mvn command works and generates properly with the excluded classes?

@eaball35
Copy link
Contributor Author

eaball35 commented May 4, 2021

Thanks @eaball35! Can you confirm that running the updated mvn command works and generates properly with the excluded classes?

Yes I triggered off this commit and was able to successfully generate cloud-rad docs without the excluded classes included.

Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one question

@eaball35 eaball35 merged commit be81ef8 into master May 5, 2021
@eaball35 eaball35 deleted the cloud-rad-java branch May 5, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants