chore: fix tests #83
Merged
chore: fix tests #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igorbernstein2
commented
Nov 12, 2019
•
- Fix bug in the instance admin IT. This was unnoticed because our presubmits target a development instance (I just changed that)
- Move auto-value back as a provided dep in the main dependency list. This caused issues in intellij when annotation processing was disabled
- Disable concurrent unit tests, it makes the autogen tests flaky
* Fix bug in the instance admin IT. This was unnoticed because our presubmits target a development instance (I just changed that) * Move auto-value back as a provided dep in the main dependency list. This caused issues in intellij when annotation processing was disabled
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
Coverage ? 81.02%
Complexity ? 937
=========================================
Files ? 95
Lines ? 5849
Branches ? 311
=========================================
Hits ? 4739
Misses ? 919
Partials ? 191Continue to review full report at Codecov.
|
kolea2
reviewed
Nov 12, 2019
...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java
Show resolved
Hide resolved
kolea2
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.