Skip to content

chore: use BaseApiTracer and BaseApiTracerFactory #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2021
Merged

chore: use BaseApiTracer and BaseApiTracerFactory #879

merged 2 commits into from
Jul 12, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jun 21, 2021 •
edited
Loading

Extends BaseApiTracer and BaseApiTracerFactory instead of implementing ApiTracer and ApiTracerFactory after gax change is picked up. New methods could be added to ApiTracer and won't break the client.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested a review from a team as a code owner June 21, 2021 19:27
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jun 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@mutianf mutianf added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. labels Jun 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jun 22, 2021
@mutianf mutianf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2021
igorbernstein2
igorbernstein2 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Jul 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7d5108e into googleapis:master Jul 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 12, 2021
@mutianf mutianf deleted the throttle_stats branch July 12, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutianf @igorbernstein2