Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

chore(WIP): Proof of concept demo GraalVM Kokoro Scripts #583

Closed
wants to merge 2 commits into from

Conversation

dzou
Copy link

@dzou dzou commented Aug 31, 2021

This PR introduces GraalVM integration testing.

@Neenu1995 @lesv

@dzou dzou requested a review from a team as a code owner August 31, 2021 20:29
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the googleapis/java-secretmanager API. label Aug 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
@lesv
Copy link
Contributor

lesv commented Aug 31, 2021

@dzou Are you asking for a review? build.sh is templated and once you have something that works, we can help you modify the templates to distribute it everywhere.

@lesv
Copy link
Contributor

lesv commented Aug 31, 2021

The pom.xml is probably also templated.

@dzou
Copy link
Author

dzou commented Aug 31, 2021

@dzou Are you asking for a review? build.sh is templated and once you have something that works, we can help you modify the templates to distribute it everywhere.

Hey @lesv, @Neenu1995 -- Sorry for any confusion. I just wanted to create this PR to see if the GraalVM Kokoro Job would build and run successfully in the presubmit.

I think we have a success for the GraalVM kokoro run:
Screenshot from 2021-08-31 16-48-33

Here is the link: https://source.cloud.google.com/results/invocations/3639ad3e-8411-49e4-9c01-382bda6b00b2/targets

I think this PR is a good summary of the changes we would need to make (no need to for a full merge to run the tests). Thoughts on the next steps? Maybe you may be amenable to me updating the templates -- It seems like it might be possible to add the changes to the templates and extend things cleanly: changing both the build.sh and pom.xml should be a no-op, and I think it's only the addition of the graalvm-native.cfg which opts-in a repository for GraalVM testing (which can be done one-by-one for each repository to opt-in slowly).

@Neenu1995 Neenu1995 changed the title Setup GraalVM Kokoro Scripts chore(WIP): Setup GraalVM Kokoro Scripts Aug 31, 2021
@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 31, 2021
@dzou dzou changed the title chore(WIP): Setup GraalVM Kokoro Scripts chore(WIP): Proof of concept demo GraalVM Kokoro Scripts Sep 16, 2021
@dzou dzou added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@dzou dzou closed this Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: secretmanager Issues related to the googleapis/java-secretmanager API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants