feat: introduce Maven configuration for GraalVM testing #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
lesv
approved these changes
Sep 22, 2021
pom.xml
Outdated
Comment on lines
844
to
851
| <repositories> | ||
| <repository> | ||
| <id>snapshots-repo</id> | ||
| <url>https://google.oss.sonatype.org/content/repositories/snapshots</url> | ||
| <releases><enabled>false</enabled></releases> | ||
| <snapshots><enabled>true</enabled></snapshots> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
Can't you just use the -Pallow-snapshots
There was a problem hiding this comment.
Done, I removed this. We will no longer be using snapshots as we will try to eventually pursue putting configuration into java-core or one of the shared dependencies.
|
Waiting to change the artifact name before merging. |
Artifact renamed to |
This was referenced Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Maven project and Kokoro configuration for GraalVM native image testing.
With guidance from @lesv and @Neenu1995, our plan is to introduce changes that will be no-op (these change should not affect existing projects) while allowing individual repositories to opt-in GraalVM testing.
Summary of the changes proposed:
native) which contains the dependencies and plugins to run all unit and integration tests compiled with GraalVM with a single command (mvn test -Pnative -Penable-integration-tests). This should also be a transparent change for existing projects as the changes are only enabled with activation of the profile.A demo of this performed on the Secret Manager repo: googleapis/java-secretmanager#583
cc/ @suztomo