-
Notifications
You must be signed in to change notification settings - Fork 131
feat: specify isolation level per transaction #3704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `default_isolation_level` property for the Connection API. This property will be used by the JDBC driver and PGAdapter to set a default isolation level for all read/write transactions that are executed by a connection. Support for setting an isolation level for a single transaction will be added in a follow-up pull request.
Add an option to specify the isolation level for a single transaction. This isolation level overrides the current default isolation level that has been set for the connection. This option only has an effect for read/write transactions.
9cbacff
to
9f88545
Compare
olavloite
commented
Mar 25, 2025
@@ -100,6 +100,14 @@ public static AbstractStatementParser getInstance(Dialect dialect) { | |||
} | |||
} | |||
|
|||
static final Set<String> ddlStatements = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These statements have been moved up in this file to make sure that they are executed before the static block on line 151.
sakthivelmanii
approved these changes
Mar 28, 2025
Check if making a couple of test classes public fixes the weird native image build error.
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Mar 31, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.89.0` -> `6.90.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.90.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6900-2025-03-31) ##### Features - Add default_isolation_level connection property ([#​3702](googleapis/java-spanner#3702)) ([9472d23](googleapis/java-spanner@9472d23)) - Adds support for Interval datatype in Java client ([#​3416](googleapis/java-spanner#3416)) ([8be8f5e](googleapis/java-spanner@8be8f5e)) - Integration test for End to End tracing ([#​3691](googleapis/java-spanner#3691)) ([bf1a07a](googleapis/java-spanner@bf1a07a)) - Specify isolation level per transaction ([#​3704](googleapis/java-spanner#3704)) ([868f30f](googleapis/java-spanner@868f30f)) - Support PostgreSQL isolation level statements ([#​3706](googleapis/java-spanner#3706)) ([dda2e1d](googleapis/java-spanner@dda2e1d)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: a63885015974acb6061bae5ca3b9d61136991376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to specify the isolation level for a single transaction. This isolation level overrides the current default isolation level that has been set for the connection. This option only has an effect for read/write transactions.