Skip to content

test: mock Spanner did not create jsonb parameters #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

test: mock Spanner did not create jsonb parameters #2182

merged 1 commit into from
Dec 5, 2022

Conversation

olavloite
Copy link
Collaborator

The mock Spanner server that is used for testing did not create statements with PG JSONB typed parameters. Instead, all parameters with TypeCode JSON would create statements with parameters of type JSON, regardless of any TypeAnnotationCode.

@olavloite
test: mock Spanner did not create jsonb parameters
afb3260 
The mock Spanner server that is used for testing did not create statements
with PG JSONB typed parameters. Instead, all parameters with TypeCode JSON
would create statements with parameters of type JSON, regardless of any
TypeAnnotationCode.
@olavloite olavloite added the type: cleanup An internal cleanup or hygiene concern. label Dec 4, 2022
@olavloite olavloite requested a review from a team as a code owner December 4, 2022 11:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 4, 2022
@olavloite olavloite requested a review from rajatbhatta December 4, 2022 17:59
rajatbhatta
rajatbhatta approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit d82115d into main Dec 5, 2022
@olavloite olavloite deleted the use-jsonb-in-mock-server branch December 5, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olavloite @rajatbhatta