Skip to content

chore: fix synth.py error and enable multiple autosynth commits #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

chore: fix synth.py error and enable multiple autosynth commits #215

merged 1 commit into from
Mar 30, 2020

Conversation

chingor13
Copy link
Contributor

Fixes #199

@chingor13 chingor13 requested a review from frankyn March 30, 2020 15:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #215   +/-   ##
========================================
  Coverage      63.5%   63.5%           
  Complexity      540     540           
========================================
  Files            30      30           
  Lines          4759    4759           
  Branches        427     427           
========================================
  Hits           3022    3022           
  Misses         1577    1577           
  Partials        160     160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010c112...7f240cd. Read the comment docs.

@frankyn frankyn merged commit 2faeb54 into master Mar 30, 2020
@frankyn frankyn deleted the chingor13-patch-1 branch March 30, 2020 16:56
@frankyn frankyn mentioned this pull request Mar 30, 2020
Closed
yoshi-automation added a commit that referenced this pull request Mar 30, 2020
@yoshi-automation
chore: fix synth.py error and enable multiple autosynth commits (#215)
2856f28 
2faeb54
commit 2faeb54
Author: Jeff Ching <[email protected]>
Date:   Mon Mar 30 09:56:42 2020 -0700

    chore: fix synth.py error and enable multiple autosynth commits (#215)
chingor13 pushed a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
chore: update common templates (#216)
b5dce9e 
* Change triggered by none of the following:
This git repo (https://github.com/googleapis/java-storage.git)

* docs: clarify documentation on date formats (#196)

9b4af58
commit 9b4af58
Author: johnalowry <[email protected]>
Date:   Wed Mar 18 17:01:52 2020 -0700

    docs: clarify documentation on date formats (#196)

    System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

    The output was

    Blob updatetime: 1582157090238

    I verified that this was ms after epoch:

    $ date -d @1582157090
    Wed 19 Feb 2020 04:04:50 PM PST

    I also traced the code to this function:

    https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

    I assumed that create and delete times used the same format.

* chore: use java helper for templates (#195)

b0ffd0b
commit b0ffd0b
Author: Jeff Ching <[email protected]>
Date:   Wed Mar 18 17:04:08 2020 -0700

    chore: use java helper for templates (#195)

    We are cleaning up usage of common templates in synthtool. This allows us the cleanup usage in a centralized place rather than in 60+ repos

* deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

84faad1
commit 84faad1
Author: WhiteSource Renovate <[email protected]>
Date:   Sat Mar 21 03:39:53 2020 +0100

    deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

* deps: update dependency com.google.api:api-common to v1.9.0 (#209)

789ceaa
commit 789ceaa
Author: WhiteSource Renovate <[email protected]>
Date:   Thu Mar 26 00:22:02 2020 +0100

    deps: update dependency com.google.api:api-common to v1.9.0 (#209)

    This PR contains the following updates:

    | Package | Update | Change |
    |---|---|---|
    | [com.google.api:api-common](https://togithub.com/googleapis/api-common-java) | minor | `1.8.1` -> `1.9.0` |

    ---

    ### Release Notes

    <details>
    <summary>googleapis/api-common-java</summary>

    ### [`v1.9.0`](https://togithub.com/googleapis/api-common-java/releases/v1.9.0)

    [Compare Source](https://togithub.com/googleapis/api-common-java/compare/v1.8.1...v1.9.0)

    03-25-2020 14:09 PST

    #### New Features

    -   Add `@BetaApi` `ApiFutres.catchingAsync()` ([#&#8203;117](https://togithub.com/googleapis/api-common-java/pull/117))

    ##### Dependencies

    -   Update guava to v28.2-android ([#&#8203;110](https://togithub.com/googleapis/api-common-java/pull/110))
    -   Update error_prone_annotations to v2.2.3 ([#&#8203;111](https://togithub.com/googleapis/api-common-java/pull/111))

    </details>

    ---

    ### Renovate configuration

    📅 **Schedule**: At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-storage).

* samples: fix install-without-bom version (#211)

08750db
commit 08750db
Author: Jeff Ching <[email protected]>
Date:   Fri Mar 27 15:09:06 2020 -0700

    samples: fix install-without-bom version (#211)

    * samples: fix install-without-bom version

    * samples: fix snapshot version

    * samples: fix libraries-bom version

* fix: storage-client-lib-docs to right location (#213)

133d137
commit 133d137
Author: Frank Natividad <[email protected]>
Date:   Fri Mar 27 15:44:02 2020 -0700

    fix: storage-client-lib-docs to right location (#213)

* deps: update conformance test dep (#210)

010c112
commit 010c112
Author: JesseLovelace <[email protected]>
Date:   Fri Mar 27 15:59:00 2020 -0700

    deps: update conformance test dep (#210)

    * Update conformance test dep

    * Update conformance test dep

* chore: fix synth.py error and enable multiple autosynth commits (#215)

2faeb54
commit 2faeb54
Author: Jeff Ching <[email protected]>
Date:   Mon Mar 30 09:56:42 2020 -0700

    chore: fix synth.py error and enable multiple autosynth commits (#215)

* deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)

be74072
commit be74072
Author: WhiteSource Renovate <[email protected]>
Date:   Mon Mar 30 22:25:27 2020 +0200

    deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for java-storage
3 participants
@chingor13 @frankyn @googlebot