Skip to content

Commit b58fc29

Browse files
fix: manual update for renovate-bot google cloud storage v7 (#1262)
* fix(deps): update dependency @google-cloud/storage to v7 * updating system tests to accommodate version update * reset formatting * Revert "updating system tests to accommodate version update" This reverts commit 8611846. reset formatting after system test update * updating system tests to accommodate version update --------- Co-authored-by: Renovate Bot <[email protected]>
1 parent b70d3a4 commit b58fc29

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"uuid": "^9.0.0"
6262
},
6363
"devDependencies": {
64-
"@google-cloud/storage": "^6.0.0",
64+
"@google-cloud/storage": "^7.0.0",
6565
"@types/big.js": "^6.2.0",
6666
"@types/extend": "^3.0.1",
6767
"@types/is": "0.0.22",

samples/authViewTutorial.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,8 @@ function main(
103103
sharedMetadata.access = sharedAccessEntries;
104104

105105
// Make API request to update dataset metadata
106-
const [updatedSharedMetadata] = await sharedDataset.setMetadata(
107-
sharedMetadata
108-
);
106+
const [updatedSharedMetadata] =
107+
await sharedDataset.setMetadata(sharedMetadata);
109108

110109
console.log(`Dataset ${updatedSharedMetadata.id} updated.`);
111110
// [END bigquery_avt_shared_dataset_access]
@@ -129,9 +128,8 @@ function main(
129128
sourceMetadata.access = sourceAccessEntries;
130129

131130
// Make API request to update source dataset metadata
132-
const [updatedSourceMetadata] = await sourceDataset.setMetadata(
133-
sourceMetadata
134-
);
131+
const [updatedSourceMetadata] =
132+
await sourceDataset.setMetadata(sourceMetadata);
135133

136134
console.log(`Dataset ${updatedSourceMetadata.id} updated.`);
137135
// [END bigquery_avt_source_dataset_access]

samples/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"dependencies": {
1919
"@google-cloud/bigquery": "^7.1.1",
20-
"@google-cloud/storage": "^6.0.0",
20+
"@google-cloud/storage": "^7.0.0",
2121
"google-auth-library": "^9.0.0",
2222
"readline-promise": "^1.0.4",
2323
"yargs": "^17.0.0"

system-test/bigquery.ts

+9-1
Original file line numberDiff line numberDiff line change
@@ -1818,7 +1818,15 @@ describe('BigQuery', () => {
18181818
});
18191819

18201820
const deleteBucketPromises = buckets
1821-
.filter(bucket => isResourceStale(bucket.metadata.timeCreated))
1821+
.filter(bucket => {
1822+
try {
1823+
if (typeof bucket.metadata.timeCreated === 'string') {
1824+
isResourceStale(bucket.metadata.timeCreated);
1825+
}
1826+
} catch {
1827+
throw Error('timeCreated on type BucketMetadata cannot be undefined');
1828+
}
1829+
})
18221830
.map(async b => {
18231831
const [files] = await b.getFiles();
18241832
await Promise.all(files.map(f => f.delete()));

0 commit comments

Comments
 (0)