Skip to content

Commit 906ac79

Browse files
authored
fix: Fix flakey test by extending timeout (#1350)
* fix: Fix flakey test by extending timeout Add timeout to the read syncronously test as it is blocking a few tests from being merged. * Increase the timeout to unblock the CI pipeline Tests are failing for non-windows cases due to timeouts. Add this line of code for timeouts. * run linter
1 parent 04517a5 commit 906ac79

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

system-test/bigtable.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,8 @@ describe('Bigtable', () => {
155155

156156
it('should test Iam permissions for the instance', async () => {
157157
const permissions = ['bigtable.tables.get', 'bigtable.tables.readRows'];
158-
const [grantedPermissions] = await INSTANCE.testIamPermissions(
159-
permissions
160-
);
158+
const [grantedPermissions] =
159+
await INSTANCE.testIamPermissions(permissions);
161160
assert.strictEqual(grantedPermissions.length, permissions.length);
162161
permissions.forEach(permission => {
163162
assert.strictEqual(grantedPermissions.includes(permission), true);

test/readrows.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ describe('Bigtable/ReadRows', () => {
4242
service = new BigtableClientMockService(server);
4343
});
4444

45-
it('should create read stream and read synchronously', done => {
45+
it('should create read stream and read synchronously', function (done) {
46+
this.timeout(60000);
47+
4648
// 1000 rows must be enough to reproduce issues with losing the data and to create backpressure
4749
const keyFrom = 0;
4850
const keyTo = 1000;

0 commit comments

Comments
 (0)