OpenTelemetry Trace context Global Propagators are default set to W3CTraceContextPropagator #2208
Assignees
Labels
api: spanner
Issues related to the googleapis/nodejs-spanner API.
Comments
|
Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node) |
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jan 3, 2025
🤖 I have created a release *beep* *boop* --- ## [7.17.1](https://togithub.com/googleapis/nodejs-spanner/compare/v7.17.0...v7.17.1) (2025-01-03) ### Bug Fixes * Remove default global trace context propagator ([#2209](https://togithub.com/googleapis/nodejs-spanner/issues/2209)) ([7898e0c](https://togithub.com/googleapis/nodejs-spanner/commit/7898e0ce0477e2d4327822ac26a2674203b47a64)), closes [#2208](https://togithub.com/googleapis/nodejs-spanner/issues/2208) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
alkatrivedi
pushed a commit
that referenced
this issue
Jan 9, 2025
alkatrivedi
pushed a commit
that referenced
this issue
Jan 9, 2025
🤖 I have created a release *beep* *boop* --- ## [7.17.1](https://togithub.com/googleapis/nodejs-spanner/compare/v7.17.0...v7.17.1) (2025-01-03) ### Bug Fixes * Remove default global trace context propagator ([#2209](https://togithub.com/googleapis/nodejs-spanner/issues/2209)) ([7898e0c](https://togithub.com/googleapis/nodejs-spanner/commit/7898e0ce0477e2d4327822ac26a2674203b47a64)), closes [#2208](https://togithub.com/googleapis/nodejs-spanner/issues/2208) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
alkatrivedi
added a commit
that referenced
this issue
Feb 26, 2025
#2214) * feat(spanner): add support for Multiplexed Session for Read Only Transactions * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(main): release 7.17.0 (#2185) * chore(main): release 7.17.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: surbhigarg92 <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * fix: remove default global trace context propagator (#2209) Fixes #2208 * chore(main): release 7.17.1 (#2210) :robot: I have created a release *beep* *boop* --- ## [7.17.1](https://togithub.com/googleapis/nodejs-spanner/compare/v7.17.0...v7.17.1) (2025-01-03) ### Bug Fixes * Remove default global trace context propagator ([#2209](https://togithub.com/googleapis/nodejs-spanner/issues/2209)) ([7898e0c](https://togithub.com/googleapis/nodejs-spanner/commit/7898e0ce0477e2d4327822ac26a2674203b47a64)), closes [#2208](https://togithub.com/googleapis/nodejs-spanner/issues/2208) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * refactor: test * refactor: test * refactor: test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactor * refactor * tests: changes for kokoro pipeline * refactor * refactor * doc: refactor * test: refactor test to support mux session * refactor test * refactor * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactor --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: surbhigarg92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent release introduced a feature E2E tracing which added the global propagator here
This should not be added as default in the SDK instead customers should add it.
A step-by-step description of how to reproduce the issue, based on the linked reproduction.
propagation.setGlobalPropagator(new CompositePropagator()());A clear and concise description of what the bug is, and what you expected to happen.
Propagators should not be added as default. This is a breaking behavior for customers already using propagators
This is recent change in 7.17.0
The text was updated successfully, but these errors were encountered: