Skip to content

chore: update prediction endpoint #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2021
Merged

chore: update prediction endpoint #221

merged 2 commits into from
Feb 16, 2021

Conversation

dizcology
Copy link
Contributor

@dizcology dizcology commented Feb 11, 2021 •
edited
Loading

Update predict samples to send request to the main api_endpoint.

DO NOT MERGE: until sample tests passing on a rerun in the week of Feb 16.

@dizcology dizcology requested review from a team as code owners February 11, 2021 19:12
@dizcology dizcology requested review from tmatsuo and removed request for a team February 11, 2021 19:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2021
@dizcology dizcology requested review from vinnysenthil and removed request for tmatsuo February 11, 2021 19:12
@dizcology dizcology added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 11, 2021
vinnysenthil
vinnysenthil approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@vinnysenthil vinnysenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving for code changes. Still don't merge until tests are passing next week.

@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2021
@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2021
@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2021
@dizcology dizcology removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 16, 2021
@dizcology dizcology merged commit 07499cc into googleapis:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil vinnysenthil approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dizcology @vinnysenthil @yoshi-kokoro