Skip to content

feat: support subtraction in DATETIME/TIMESTAMP columns with timedelta columns #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 14, 2025
Merged

feat: support subtraction in DATETIME/TIMESTAMP columns with timedelta columns #1390

merged 13 commits into from
Feb 14, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Feb 12, 2025 •
edited by tswast
Loading

BEGIN_COMMIT_OVERRIDE
feat: support subtraction in DATETIME/TIMESTAMP columns with timedelta columns (#1390)
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 12, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 12, 2025
@sycai sycai changed the title chore: support timestamp_subb chore: support timestamp_sub Feb 12, 2025
@sycai sycai marked this pull request as ready for review February 12, 2025 18:51
@sycai sycai requested review from a team as code owners February 12, 2025 18:51
@sycai sycai requested a review from TrevorBergeron February 12, 2025 18:51
@sycai sycai requested a review from chelsea-lin February 12, 2025 18:51
@sycai sycai force-pushed the sycai_timestamp_sub branch from 25f3919 to e0b5ee9 Compare February 13, 2025 17:55
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2025
chelsea-lin
chelsea-lin reviewed Feb 13, 2025
View reviewed changes
bigframes/operations/timedelta_ops.py Outdated
return input_types[0]

raise TypeError(
f"unsupported types for timestamp_add. left: {input_types[0]} right: {input_types[1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: timestamp_sub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sycai sycai enabled auto-merge (squash) February 13, 2025 21:22
@sycai sycai merged commit 50ad3a5 into main Feb 14, 2025
23 checks passed
@sycai sycai deleted the sycai_timestamp_sub branch February 14, 2025 00:51
@tswast tswast changed the title chore: support timestamp_sub feat: support subtraction in DATETIME/TIMESTAMP columns Feb 19, 2025
@release-please release-please bot mentioned this pull request Feb 19, 2025
Merged
@tswast tswast changed the title feat: support subtraction in DATETIME/TIMESTAMP columns feat: support subtraction in DATETIME/TIMESTAMP columns with timedelta columns Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@arwas11 arwas11

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sycai @chelsea-lin @bigframes-bot @arwas11