Skip to content

fix: use == instead of is for timedelta type equality checks #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2025
Merged

fix: use == instead of is for timedelta type equality checks #1480

merged 4 commits into from
Mar 11, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Mar 10, 2025

This allows user to use expressions like

my_series.astype(pd.ArrowDtype(pa.duration('us')))

for type castings.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 10, 2025
@sycai sycai marked this pull request as ready for review March 11, 2025 00:04
@sycai sycai requested review from a team as code owners March 11, 2025 00:04
@sycai sycai requested a review from tswast March 11, 2025 00:04
@sycai sycai enabled auto-merge (squash) March 11, 2025 19:50
@sycai sycai merged commit 0db248b into main Mar 11, 2025
21 of 23 checks passed
@sycai sycai deleted the sycai_td_type_eq branch March 11, 2025 21:24
@release-please release-please bot mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sycai @chelsea-lin @liujiashang