Skip to content

fix: enfore pandas version requirement <2.1.4 #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Dec 9, 2023

There seem to be a breaking change in pandas release 2.1.4 that is failing tests using pandas.read_json. This change is pinning pandas dependency version to <2.1.4 until the proper fix.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 315539920 🦕

There seem to be a breaking change in pandas release 2.1.4 that is
failing tests using `pandas.read_json`. This change is pinning pandas
dependency version to <2.1.4 until the proper fix.
@shobsi shobsi requested review from a team as code owners December 9, 2023 01:30
@shobsi shobsi requested a review from stevewalker-de December 9, 2023 01:30
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 9, 2023
@shobsi shobsi requested review from jiaxunwu and ashleyxuu December 9, 2023 01:34
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2023
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping debugging

@gcf-merge-on-green gcf-merge-on-green bot merged commit 9dd63f6 into main Dec 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-pass-system-3-11 branch December 9, 2023 02:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2023
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
There seem to be a breaking change in pandas release 2.1.4 that is failing tests using `pandas.read_json`. This change is pinning pandas dependency version to <2.1.4 until the proper fix.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes internal issue 315539920 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants