Skip to content

feat: support Series.dt.strftime #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2024
Merged

feat: support Series.dt.strftime #453

merged 5 commits into from
Mar 18, 2024

Conversation

junyazhang
Copy link
Contributor

Fixes internal bug: b/309817430 🦕

Staged doc: https://screenshot.googleplex.com/aYkRZJjm2ehx8E6

@junyazhang junyazhang requested review from a team as code owners March 15, 2024 23:29
@junyazhang junyazhang requested a review from chelsea-lin March 15, 2024 23:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 15, 2024
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@junyazhang junyazhang merged commit 8f6e955 into main Mar 18, 2024
@junyazhang junyazhang deleted the lily_strftime branch March 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants