Skip to content

feat: add GroupBy.size() to get number of rows in each group #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 24, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 20, 2024
@tswast tswast force-pushed the tswast-groupby-size branch from 20d9738 to 027d406 Compare March 20, 2024 19:01
@tswast tswast marked this pull request as ready for review March 20, 2024 19:02
@tswast tswast requested review from a team as code owners March 20, 2024 19:02
@tswast tswast requested a review from ashleyxuu March 20, 2024 19:02


def test_series_groupby_kurt(scalars_df_index, scalars_pandas_df_index):
bf_result = scalars_df_index.groupby("bool_col")["int64_too"].kurt().to_pandas()
Copy link
Collaborator Author

@tswast tswast Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved below to other series_groupby tests. I also updated the test to actually do a Series.groupby.

@tswast tswast requested review from milkshakeiii and TrevorBergeron and removed request for ashleyxuu March 29, 2024 21:03
@tswast tswast enabled auto-merge (squash) May 24, 2024 21:29
@tswast tswast disabled auto-merge May 24, 2024 21:51
@tswast tswast enabled auto-merge (squash) May 24, 2024 22:53
@tswast tswast merged commit 1fca588 into main May 24, 2024
20 of 21 checks passed
@tswast tswast deleted the tswast-groupby-size branch May 24, 2024 23:57
@tswast
Copy link
Collaborator Author

tswast commented Jun 24, 2024

See also, follow-up PR #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants