Skip to content

feat: support the score method for PaLM2TextGenerator #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2024
Merged

feat: support the score method for PaLM2TextGenerator #634

merged 4 commits into from
Apr 25, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #334660953 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu April 23, 2024 17:07
@ashleyxuu ashleyxuu requested review from a team as code owners April 23, 2024 17:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 23, 2024
@GarrettWu GarrettWu assigned ashleyxuu and unassigned orrbradford Apr 23, 2024
GarrettWu
GarrettWu reviewed Apr 23, 2024
View reviewed changes
GarrettWu
GarrettWu reviewed Apr 24, 2024
View reviewed changes
@ashleyxuu ashleyxuu force-pushed the ashleyxu-support-score branch from c54effb to 562cf8d Compare April 24, 2024 22:28
GarrettWu
GarrettWu approved these changes Apr 24, 2024
View reviewed changes
@ashleyxuu ashleyxuu merged commit 3ffc1d2 into main Apr 25, 2024
15 of 16 checks passed
@ashleyxuu ashleyxuu deleted the ashleyxu-support-score branch April 25, 2024 16:39
@release-please release-please bot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@ashleyxuu ashleyxuu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @GarrettWu @orrbradford