Skip to content

docs: address more technical writers' feedback #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

docs: address more technical writers' feedback #640

merged 1 commit into from
Apr 26, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested a review from chelsea-lin April 25, 2024 16:49
@ashleyxuu ashleyxuu requested review from a team as code owners April 25, 2024 16:49
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 25, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Apr 25, 2024
chelsea-lin
chelsea-lin approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GarrettWu GarrettWu removed their assignment Apr 25, 2024
@ashleyxuu ashleyxuu merged commit 1e7793c into main Apr 26, 2024
16 checks passed
@ashleyxuu ashleyxuu deleted the ashleyxu-docs-address branch April 26, 2024 16:24
@release-please release-please bot mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @chelsea-lin @GarrettWu