Skip to content

fix: allow __repr__ to work with uninitialized DataFrame/Series/Index #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jun 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #728 🦕

@tswast tswast requested review from a team as code owners June 11, 2024 18:35
@tswast tswast requested a review from Genesis929 June 11, 2024 18:35
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 11, 2024
@tswast tswast changed the title fix: allow __repr__ to work with uninitialed DataFrame/Series/Index fix: allow __repr__ to work with uninitialized DataFrame/Series/Index Jun 11, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jun 11, 2024
@tswast tswast merged commit e14c7a9 into main Jun 12, 2024
23 checks passed
@tswast tswast deleted the issue728-__repr__-with-uninitialized-objects branch June 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update __repr__ to work even when the object hasn't fully been initialized
3 participants