-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add DataFrame.to_arrow
to create Arrow Table from DataFrame
#807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
…to issue735-to_arrow-for-polars
…to issue735-to_arrow-for-polars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,292 @@ | |||
# Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file auto generated from a template? If not, can we update the copyright year to 2024
? Also check other new files too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is templated, so not much we can do.
polars_df = polars.from_arrow(arrow_table) | ||
# [END bigquery_dataframes_to_polars] | ||
|
||
assert polars_df is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert polars_df
is equal to bf_df
? Or maybe there are some diverse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could possibly compare shapes or some aggregate values. I'll give it a try.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #735 🦕