Skip to content

feat: create a separate OrderingModePartialPreviewWarning for more fine-grained warning filters #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 2, 2024

This will help make example notebook(s) that use this feature less warning heavy.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners August 2, 2024 16:09
@tswast tswast requested a review from TrevorBergeron August 2, 2024 16:09
@tswast tswast merged commit 8753bdd into main Aug 2, 2024
22 of 23 checks passed
@tswast tswast deleted the ordering-mode-custom-warning branch August 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants