Skip to content

feat: Add bigframes.streaming.to_pubsub method to create continuous query that writes to Pub/Sub #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 26, 2024
Merged

feat: Add bigframes.streaming.to_pubsub method to create continuous query that writes to Pub/Sub #801

merged 21 commits into from
Jun 26, 2024

Conversation

milkshakeiii
Copy link
Contributor

Also add script that simply creates a pubsub topic named "penguins"

@milkshakeiii milkshakeiii requested review from a team as code owners June 20, 2024 17:18
@milkshakeiii milkshakeiii requested a review from junyazhang June 20, 2024 17:18
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 20, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jun 20, 2024
@milkshakeiii milkshakeiii changed the title Add to_pubsub streaming method feat: Add to_pubsub streaming method Jun 20, 2024
@milkshakeiii milkshakeiii requested review from tswast and GarrettWu June 20, 2024 17:58
milkshakeiii
milkshakeiii commented Jun 21, 2024
View reviewed changes
Copy link
Contributor Author

@milkshakeiii milkshakeiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to sphinx documentation (toc.yaml and something.rst) Thanks

@milkshakeiii
Copy link
Contributor Author

Add to sphinx documentation (toc.yaml and something.rst) Thanks

This will be added in a follow-up.

@milkshakeiii milkshakeiii reopened this Jun 21, 2024
@tswast tswast changed the title feat: Add to_pubsub streaming method feat: Add bigframes.stream.to_pubsub method to create continuous query that writes to Pub/Sub Jun 24, 2024
@tswast tswast changed the title feat: Add bigframes.stream.to_pubsub method to create continuous query that writes to Pub/Sub feat: Add bigframes.streaming.to_pubsub method to create continuous query that writes to Pub/Sub Jun 24, 2024
tswast
tswast reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions. Let me know what you think about the name change and if it's feasible to test for pub/sub message.

@milkshakeiii milkshakeiii merged commit b47f32d into main Jun 26, 2024
23 checks passed
@milkshakeiii milkshakeiii deleted the b333824051-streaming-pubsub branch June 26, 2024 20:48
@release-please release-please bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@junyazhang junyazhang Awaiting requested review from junyazhang junyazhang is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@GarrettWu GarrettWu Awaiting requested review from GarrettWu

Assignees

@stevewalker-de stevewalker-de

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium. status: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milkshakeiii @tswast @stevewalker-de